ld01blog

Patch testing: Hardcoded values in edit lock window

Hello! I’m here to explain the way i tested patch #65171 related with WordPress team collaboration causing progress to be lost between post editors.

The What

The bug report shows that the client heartbeat that keeps the connection alive between the PHP web server and client has unexpected behavior when using a custom check for the lock window that allows another user to take over someones work and override it making them lose all their progress during a generous time window of ~30 seconds to 120 seconds that is because the PHP server thinks the client dies early because of the hardcoded value assigned to the heartbeat doesn’t sync when the value of the window lock is customized.

Example before the patch.

The patch

i used the patch described on the bug report and fixed the issue with the client and server not being in sync when the window lock is customized solving the issue described on my environment more details on my patch test report on the patch inside trac.